Skip to content

Conversation

@KirkMunroSagent
Copy link

@KirkMunroSagent KirkMunroSagent commented Oct 7, 2024

This is my first pull request for this project.

The goal here is simple: to update nswag such that it respects the required attribute on form-data parameters (currently it does not).

Please let me know if the proposed changes are in an inappropriate location in this project. After stepping through the code multiple times, this seems like the right place for the changes that I included, but if not, I'll update the PR according to the feedback.

The fix I'm ultimately hoping comes out of these changes, is for the nswag CLI to be able to generate a C# client for a REST API containing one or more endpoint that accept form-data input with required parameters. Currently they generate as optional parameters, so I'd like to get that corrected. If additional changes beyond these are required to make that happen, please let me know that as well.

Thank you!

@KirkMunroSagent KirkMunroSagent changed the title Fix required handling for formdata properties [Code Generation] Fix required handling for formdata properties Nov 21, 2024
@KirkMunroSagent KirkMunroSagent changed the title [Code Generation] Fix required handling for formdata properties [Client Generation] Fix required handling for formdata properties Nov 21, 2024
@KirkMunroSagent KirkMunroSagent mentioned this pull request Nov 21, 2024
@KirkMunroSagent
Copy link
Author

KirkMunroSagent commented Oct 7, 2025

@lahma I opened this PR a year ago today. What does it take to get a PR workflow approved so that the PR can be merged-in?

@KirkMunroSagent
Copy link
Author

@RicoSuter: Maybe you can share some insight? I have a PR open for a year with no feedback of any kind on what needs to be done to get it approved. It has been complete and ready to go for a year. I have issue #5261 where I identified a problem, and the solution, and @lahma suggested I open a PR, but I'm hesitant to do any work here when PRs are not properly managed by the repo owners. And I have been running into breaking changes over the past several releases, such as the one identified in #5242, which I'm pretty sure still isn't fixed in 14.6.2. I want to keep using nswag, we're quite dependent on it at the moment, but I've been finding it very unreliable lately, and the maintainers haven't been responsive so I'm not sure what to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant