Skip to content

Fix legacy document transformation #5315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copyleftproducts wants to merge 2 commits into
base: master
Choose a base branch
from
+1 −14
Open

Fix legacy document transformation #5315

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ecbd722
Remove unused property from legacy document transformation
copyleftproducts Dec 14, 2025
971f973
Do not overwrite legacy documents with transformations
copyleftproducts Dec 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 1 addition & 14 deletions src/NSwag.Commands/NSwagDocumentBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,14 +167,7 @@ protected static async Task<TDocument> LoadAsync<TDocument>(
where TDocument : NSwagDocumentBase, new()
{
var data = File.ReadAllText(filePath);
data = TransformLegacyDocument(data, out var requiredLegacyTransformations);

if (requiredLegacyTransformations)
{
// Save now to avoid transformations
var document = LoadDocument<TDocument>(filePath, data);
await document.SaveAsync();
}
data = TransformLegacyDocument(data, out var _);

if (applyTransformations)
{
Expand Down Expand Up @@ -513,12 +506,6 @@ private static string TransformLegacyDocument(string data, out bool saveFile)
saveFile = true;
}

if (data.Contains("\"noBuild\":") && !data.Contains("RequireParametersWithoutDefault", StringComparison.OrdinalIgnoreCase))
{
data = data.Replace("\"noBuild\":", "\"requireParametersWithoutDefault\": true, \"noBuild\":");
saveFile = true;
}

if (data.Contains("assemblyTypeToSwagger"))
{
data = data.Replace("assemblyTypeToSwagger", "typesToSwagger");
Expand Down