Skip to content

feat: enable react-hooks/react-compiler ESLint rule #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lixiaoyan wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat: enable react-hooks/react-compiler ESLint rule #249

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@rightcapital-eslint-config-cf0cb21f-4a5d-4f52-83d4-d0b30de4c4c7.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "major",
"comment": "feat: enable react-hooks/react-compiler ESLint rule",
"packageName": "@rightcapital/eslint-config",
"email": "[email protected]",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion packages/eslint-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"eslint-plugin-jsx-a11y": "6.10.2",
"eslint-plugin-lodash": "8.0.0",
"eslint-plugin-n": "17.18.0",
"eslint-plugin-react-hooks": "5.2.0",
"eslint-plugin-react-hooks": "6.0.0-rc.1",
"eslint-plugin-simple-import-sort": "12.1.1",
"eslint-plugin-unicorn": "56.0.1",
"eslint-plugin-unused-imports": "4.1.4",
Expand Down
4 changes: 4 additions & 0 deletions packages/eslint-config/src/config/mixin/react.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ const config: TSESLint.FlatConfig.ConfigArray = [
// https://github.com/facebook/react/blob/1204c789776cb01fbaf3e9f032e7e2ba85a44137/packages/eslint-plugin-react-hooks/src/ExhaustiveDeps.js
'react-hooks/exhaustive-deps': 'error',

// React compiler related rules
// https://github.com/facebook/react/blob/2bcf06b69254cad6f7e702bf7d65c4f30478668c/packages/eslint-plugin-react-hooks/src/rules/ReactCompiler.ts
'react-hooks/react-compiler': 'error',

// MEMO: There are too many false positives with this rule.
'@eslint-react/hooks-extra/no-direct-set-state-in-use-effect': 'off',

Expand Down
Loading