fix(nix): move build tools from buildInputs to nativeBuildInputs#1047
Open
t4min0 wants to merge 1 commit intoRightNow-AI:mainfrom
Open
fix(nix): move build tools from buildInputs to nativeBuildInputs#1047t4min0 wants to merge 1 commit intoRightNow-AI:mainfrom
t4min0 wants to merge 1 commit intoRightNow-AI:mainfrom
Conversation
perl, clang, and pkg-config are build-time tools that need to be on $PATH during cargo build. In Nix, nativeBuildInputs are added to $PATH; buildInputs are not (they go to $NIX_LDFLAGS for runtime linkage). With perl in buildInputs, the openssl-sys vendored build fails when the flake is consumed as an input from another flake: cargo:warning=configuring OpenSSL build: Command 'perl' not found. openssl stays in buildInputs (runtime linkage). clang, perl, pkg-config move to nativeBuildInputs (build tools, need $PATH). Follow-up to RightNow-AI#966. Fixes RightNow-AI#894 for flake consumers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
perl, clang, and pkg-config are build-time tools that need to be on $PATH during cargo build. In Nix, nativeBuildInputs are added to $PATH; buildInputs are not (they go to $NIX_LDFLAGS for runtime linkage).
With perl in buildInputs, the openssl-sys vendored build fails when the flake is consumed as an input from another flake:
cargo:warning=configuring OpenSSL build: Command 'perl' not found.
openssl stays in buildInputs (runtime linkage). clang, perl, pkg-config move to nativeBuildInputs (build tools, need $PATH).
Follow-up to #966. Fixes #894 for flake consumers.
Changes
openssl: stays inbuildInputs(runtime linkage dependency)clang,perl,pkg-config: moved to newnativeBuildInputs(build-time tools that must be on$PATH)Testing
cargo clippy --workspace --all-targets -- -D warningspassescargo test --workspacepassesSecurity