Add CI build job to reduce broken main#969
Open
randavidovitz wants to merge 7 commits intoRightNow-AI:mainfrom
Open
Add CI build job to reduce broken main#969randavidovitz wants to merge 7 commits intoRightNow-AI:mainfrom
randavidovitz wants to merge 7 commits intoRightNow-AI:mainfrom
Conversation
jaberjaber23
approved these changes
Apr 10, 2026
Member
jaberjaber23
left a comment
jaberjaber23
left a comment
There was a problem hiding this comment.
LGTM. Good addition of cross-platform build verification. The audit ignore for RUSTSEC-2026-0049 is appropriately documented (rumqttc upstream). Please rebase on main.
Member
|
This PR has merge conflicts. Please rebase onto the latest main branch and resolve conflicts so we can merge. |
randavidovitz
force-pushed
the
ci/add-build-job
branch
from
d3e2275 to
a87bf48
Compare
Author
|
@jaberjaber23 this indicated "1 workflow awaiting approval" |
Following rebase on head needed to fixed failure of checks 1. Formatting 2. Clippy
build is failing on dead code, i decided to add exception (ignore) this since i assume this will be used in later commits
…_arg) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…95/0096)
Resolves 11 wasmtime vulnerabilities including two severity-9 sandbox
escapes (Winch backend and aarch64 Cranelift miscompilation). Adapts
sandbox.rs func_wrap closures to wasmtime 43's split Error type: replaced
anyhow::{bail,anyhow} with wasmtime's re-exported bail!/format_err! and
updated return types from Result<_, anyhow::Error> to wasmtime::Result<_>.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
sorry ... didn't see this one before #1039 ... should be similar and it's based on the latest main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildjob to CI that runscargo build --workspace --libon all 3 platforms (ubuntu, macos, windows)Why
Previously CI only ran
cargo check(type-level validation). Actual compilation errors could slip through. This ensures the code actually compiles before merging.Testing
cargo clippy --workspace --all-targets -- -D warningspassescargo test --workspacepassesSecurity