feat(cleanup)!: replace update-pr-comment with delete-pr-comment#6
Merged
Conversation
robbertbos
requested review from
anneschuth and
uittenbroekrobbert
as code owners
anneschuth
reviewed
Feb 2, 2026
anneschuth
left a comment
anneschuth
left a comment
Member
There was a problem hiding this comment.
Looks good. This should be merged after all v1.x features and released as v2.0.0. The release workflow already handles creating the v2 major tag. Consider adding a brief migration section to the release notes explaining update-pr-comment → delete-pr-comment.
BREAKING CHANGE: The cleanup action now deletes PR comments instead of updating them with strikethrough text. - Rename `update-pr-comment` input to `delete-pr-comment` - Rename `pr-comment-updated` output to `pr-comment-deleted` - Change default from `false` to `true` (enabled by default) - Simplify implementation: delete comment instead of PATCH update Users upgrading from v1 should replace: update-pr-comment: true → delete-pr-comment: true The new default (true) means PR comments are deleted automatically when cleanup runs, matching the behavior of pr-preview-action.
anneschuth
force-pushed
the
feat/cleanup-delete-pr-comment
branch
from
ef5ecb5 to
372a918
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a PR is closed, the preview deployment is no longer relevant. A strikethrough URL in the comment adds no value - it's just visual noise. Better to simply delete the comment and keep the PR clean.
This aligns with how pr-preview-action works: delete is the default there too.
update-pr-comment: truedelete-pr-comment: truepr-comment-updatedoutputpr-comment-deletedoutputfalsetrueType of Change
Checklist
Breaking Changes
Users upgrading to v2 must replace
update-pr-commentwithdelete-pr-comment.