feat(deploy): Add QR code to PR comments#7
Merged
Conversation
robbertbos
requested review from
anneschuth and
uittenbroekrobbert
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
robbertbos
force-pushed
the
feat/qr-code-in-comment
branch
4 times, most recently
from
d37169a to
bd2b294
Compare
robbertbos
force-pushed
the
feat/qr-code-in-comment
branch
5 times, most recently
from
b3a9b46 to
c0e769f
Compare
anneschuth
reviewed
Feb 2, 2026
anneschuth
left a comment
anneschuth
left a comment
Member
There was a problem hiding this comment.
Consider changing the qr-code input default from true to false. Users who already have comment-on-pr: true would unexpectedly get QR codes in their PR comments after upgrading to a new v1.x release. Making it opt-in is safer for a minor version bump — users who want QR codes can explicitly set qr-code: true.
If you agree, the changes needed are:
deploy/action.yml: changedefault: 'true'todefault: 'false'for theqr-codeinputdeploy/README.md: update the default value in the inputs table
- Replace external QR service with local qrencode generation - QR code embedded as base64 data URI (no external API calls) - Add test workflow for QR generation, input validation, payload construction - Add justfile for development tasks (auto-manages podman) - Update CONTRIBUTING.md with simplified testing instructions
anneschuth
force-pushed
the
feat/qr-code-in-comment
branch
from
c0e769f to
d9b345e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add QR code feature to PR comments for easy mobile testing of preview deployments.
qr-code(default:true) - include QR code in PR commentqrencode(no external API calls, privacy-friendly)Also adds development tooling:
Type of Change
Checklist
Testing
qrencodejust test(act + Podman)Breaking Changes
None. The
qr-codeinput only applies whencomment-on-pr: true.