feat(deploy): add wait-for-ready feature#8
Merged
Conversation
robbertbos
requested review from
anneschuth and
uittenbroekrobbert
as code owners
Add optional health checking to wait for deployments to be reachable before continuing. New inputs: - wait-for-ready: enable waiting (default: false) - health-endpoint: path to check (default: /) - wait-timeout: max wait time in seconds (default: 300) - wait-interval: time between checks (default: 10) Also updates README: - Add wait-for-ready documentation and examples - Replace manual health check script with built-in feature - Use generic example URLs instead of specific domains - Format tables for better readability
anneschuth
force-pushed
the
feat/wait-for-ready
branch
from
055c2c6 to
af47739
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add optional health checking to wait for deployments to be reachable before continuing. This ensures that workflows can reliably wait for a deployment to be ready before proceeding with subsequent steps like integration tests.
New inputs:
wait-for-ready: enable waiting (default: false)health-endpoint: path to check (default: /)wait-timeout: max wait time in seconds (default: 300)wait-interval: time between checks (default: 10)When combined with
comment-on-pr, the PR comment only appears after the deployment is healthy.Type of Change
Checklist
Testing
Breaking Changes
None. All new inputs are optional with sensible defaults.