Skip to content

Conversation

@jbh010204
Copy link
Member

✨ 구현한 기능

  • 멘티가 신청한 멘토링 시간대 변경 기능 구현

📢 논의하고 싶은 내용

🎸 기타

@wlgns12370 wlgns12370 requested a review from Copilot March 30, 2025 09:49
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements a feature for mentees to modify their selected mentoring time slots. Key changes include:

  • Addition of a record DTO for editing mentoring times.
  • Creation of a new PATCH endpoint in the mentoring controller for changing mentoring times.
  • Extension of the domain and service layers with methods to update the mentoring apply times.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/main/java/es/princip/ringus/presentation/mentoring/dto/EditMentoringTimeRequest.java New DTO to capture mentoring ID and updated time slots.
src/main/java/es/princip/ringus/presentation/mentoring/MentoringController.java Added PATCH endpoint for editing mentoring times with session check.
src/main/java/es/princip/ringus/domain/mentoring/Mentoring.java Added a method to update apply times in the domain layer.
src/main/java/es/princip/ringus/application/mentoring/MentoringService.java Introduced transactional service method to modify mentoring times.
Comments suppressed due to low confidence (2)

src/main/java/es/princip/ringus/application/mentoring/MentoringService.java:58

  • [nitpick] The method name 'changeMentoringDate' is inconsistent with the DTO ('EditMentoringTimeRequest') and the domain method ('changeApplyTimes'). Consider renaming it to 'changeMentoringTime' for clarity.
public void changeMentoringDate(EditMentoringTimeRequest request) {

src/main/java/es/princip/ringus/presentation/mentoring/MentoringController.java:39

  • [nitpick] The endpoint '/edit/date' does not clearly reflect that it updates mentoring time slots; consider renaming it (e.g., '/edit/time') to match the request DTO and domain context.
@PatchMapping("/edit/date")

@jbh010204 jbh010204 merged commit 8be5c43 into develop May 10, 2025
1 check passed
@jbh010204 jbh010204 deleted the feature/ringus-71 branch May 10, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants