RINGUS-83 feat: 로그인 여부와 멘토, 멘티 여부 확인 기능 추가 #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wlgns12370
approved these changes
May 12, 2025
Member
wlgns12370
left a comment
wlgns12370
left a comment
There was a problem hiding this comment.
TODO 주석 하나만 표시했는 데 있는 것 모두 지워주시면 좋을 것 같아요!
|
|
||
| private final MemberRepository memberRepository; | ||
|
|
||
| // TODO: 로그인된 유저가 멘토인지 확인 |
wodydl0
reviewed
May 12, 2025
| public boolean isMenteeRole(String role) { | ||
| return "MENTEE".equals(role); | ||
| } | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
제 생각에도 이 정도는 유틸클래스의 기능을 넘어선거 같습니다. 서비스 책임 부분을 분리하는게 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 구현한 기능
📢 논의하고 싶은 내용
🎸 기타