Skip to content

Conversation

@metaprime
Copy link
Contributor

Category

This change is exactly one of the following (please change [ ] to [x]) to indicate which:

  • a bug fix (Fix #...)
  • a new Ripper
  • a refactoring
  • a style change/fix
  • a new feature

Description

The URL changed. Updated the ripper and test.

Testing

Required verification:

  • I've verified that there are no regressions in gradlew test (there are no new failures or errors).
  • I've verified that this change works as intended.
    • Downloads all relevant content.
    • Downloads content from multiple pages (as necessary or appropriate).
    • Saves content at reasonable file names (e.g. page titles or content IDs) to help easily browse downloaded content.
  • I've verified that this change did not break existing functionality (especially in the Ripper I modified).

Optional but recommended:

  • I've added a unit test to cover my change.

@metaprime metaprime requested a review from Copilot April 20, 2025 06:36
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issue #2122 by updating the URL handling in HentaiimageRipper to reflect the new domain.

  • Updated the test URL in HentaiimageRipperTest to the new domain.
  • Modified the regex in HentaiimageRipper to accept the new URL format.
  • Adjusted the error message to correspond to the updated URL.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/test/java/com/rarchives/ripme/tst/ripper/rippers/HentaiimageRipperTest.java Updated the test URL to use the new domain.
src/main/java/com/rarchives/ripme/ripper/rippers/HentaiimageRipper.java Adjusted the regex and error message for the updated URL format.
Comments suppressed due to low confidence (1)

src/main/java/com/rarchives/ripme/ripper/rippers/HentaiimageRipper.java:50

  • [nitpick] Consider updating the error message to accurately describe the expected URL format for HentaiimageRipper instead of referencing 'hitomi URL format', to avoid potential confusion.
                "https://hentai-img-xxx.com/image/ID - got " + url + " instead"

@metaprime metaprime merged commit 69c903c into main Apr 20, 2025
8 checks passed
@metaprime metaprime deleted the issue-2122-hentaiimg branch April 20, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants