Skip to content

protobuf messaging layer#3

Merged
RobertDaleSmith merged 5 commits into
mainfrom
sgowda/proto
Sep 10, 2025
Merged

protobuf messaging layer#3
RobertDaleSmith merged 5 commits into
mainfrom
sgowda/proto

Conversation

@sgowda
Copy link
Copy Markdown
Collaborator

@sgowda sgowda commented Sep 5, 2025

Simple wrapper around messages to enable dongle to respond to certain information requests from the app.

@RobertDaleSmith RobertDaleSmith merged commit 1abfeaf into main Sep 10, 2025
4 checks passed
@RobertDaleSmith
Copy link
Copy Markdown
Owner

@sgowda this looks good 🙏

At some point we should circle back and rip out this nanopb lib and include it as a git submodule. Did you need to make any direct edits to this lib?

Also do I need an updated firmware and desktop app for using protocol buff?

@sgowda
Copy link
Copy Markdown
Collaborator Author

sgowda commented Oct 1, 2025

@sgowda this looks good 🙏

At some point we should circle back and rip out this nanopb lib and include it as a git submodule. Did you need to make any direct edits to this lib?

Also do I need an updated firmware and desktop app for using protocol buff?

Sorry, I missed this comment when I was on vacation!
The nanopb dependency is unmodified. In our internal repo we copied the nanopb code as a way of forking to avoid dependency management issues. Same version is what I copied in here. There are likely better ways to manage the dependency.

@RobertDaleSmith
Copy link
Copy Markdown
Owner

@sgowda this looks good 🙏
At some point we should circle back and rip out this nanopb lib and include it as a git submodule. Did you need to make any direct edits to this lib?
Also do I need an updated firmware and desktop app for using protocol buff?

Sorry, I missed this comment when I was on vacation! The nanopb dependency is unmodified. In our internal repo we copied the nanopb code as a way of forking to avoid dependency management issues. Same version is what I copied in here. There are likely better ways to manage the dependency.

All good. This is fine for now. Later I will probably circle back and add it as a git submodule. We can version control a specific fork or commit hash for consistency.

@RobertDaleSmith RobertDaleSmith deleted the sgowda/proto branch October 27, 2025 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants