You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At some point we should circle back and rip out this nanopb lib and include it as a git submodule. Did you need to make any direct edits to this lib?
Also do I need an updated firmware and desktop app for using protocol buff?
Sorry, I missed this comment when I was on vacation!
The nanopb dependency is unmodified. In our internal repo we copied the nanopb code as a way of forking to avoid dependency management issues. Same version is what I copied in here. There are likely better ways to manage the dependency.
@sgowda this looks good 🙏
At some point we should circle back and rip out this nanopb lib and include it as a git submodule. Did you need to make any direct edits to this lib?
Also do I need an updated firmware and desktop app for using protocol buff?
Sorry, I missed this comment when I was on vacation! The nanopb dependency is unmodified. In our internal repo we copied the nanopb code as a way of forking to avoid dependency management issues. Same version is what I copied in here. There are likely better ways to manage the dependency.
All good. This is fine for now. Later I will probably circle back and add it as a git submodule. We can version control a specific fork or commit hash for consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple wrapper around messages to enable dongle to respond to certain information requests from the app.