Merged
Conversation
game:GetService("Workspace") is unnecessary, workspace is global
https://create.roblox.com/docs/reference/engine/globals/RobloxGlobals#workspace
I see no purpose of recommending that
There was a problem hiding this comment.
Hi @RuizuKun-Dev, thanks so much for helping improve the Roblox creator documentation! Our technical writing team will review your pull request soon. In the meantime, please ensure you've read through the README.md, contribution guidelines, and style recommendations.
|
For some reason, they insist on using the game GetService("Workspace"), but why is "workspace" global then?? |
IgnisRBX
approved these changes
Feb 28, 2025
Contributor
|
Fair point, all are valid and there's no absolutely compelling reason to recommend the first one, except that it matches the pattern of including other services. We can omit the "recommended" part here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
game:GetService("Workspace") is unnecessary, workspace is global https://create.roblox.com/docs/reference/engine/globals/RobloxGlobals#workspace
I see no purpose of recommending that, using GetService for workspace is sacrilegious
Changes
Checks
By submitting your pull request for review, you agree to the following: