Skip to content

AudioRecorder and Issue Request #1104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 15, 2025
Merged

AudioRecorder and Issue Request #1104

merged 11 commits into from
May 15, 2025

Conversation

karl-police
Copy link
Contributor

@karl-police karl-police commented May 13, 2025

Changes

In-reality I wanted to ask question. To find a valid way to do it, I've updated AudioRecorder, so that now I can use this text field here, and type my question. Because issue requests are disabled.

Info is from https://create.roblox.com/docs/en-us/release-notes/release-notes-671 and https://devforum.roblox.com/t/release-notes-for-671 and own testing in the current public version through Fast Flags.

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

 

Issue

Alright. Now, to the issue.

In https://create.roblox.com/docs/en-us/reference/engine/classes/ProximityPrompt for instance, you can find a text that says

The example below generates a custom

which is in a Code Sample, and that's currently not a thing

But what I am trying to say is, that there are pages, that aren't in this Repository. And they can not be edited :(
There were moments where I wanted to edit something. I've probably forgotten. But where do I go then? 🤔 Do I actually just go on the Developer Forums with a Bug Report for everything?

Please fix.

@karl-police karl-police requested a review from a team as a code owner May 13, 2025 22:15
@github-actions github-actions bot added the engine reference Changes the Engine API Reference documentation label May 13, 2025
@IgnisRBX
Copy link
Contributor

Hi @karl-police ,
Good questions! The code samples are linked up separately, as in this section for ProximityPrompt:

code_samples:
  - using-a-proximity-prompt-with-a-seat
  - generating-a-custom-proximity-prompt
  - healing-proximity-prompt

If you find a particular code sample to be outright wrong or totally outdated, feel free to submit a PR that removes the link from the list (which will hide that sample), and we'll take a look at whether it should be removed outright or just updated.

If you want to provide feedback on a particular aspect of a code sample, please post in this forum thread which we actively monitor weekly and take action on pretty quickly:
https://devforum.roblox.com/t/typos-minor-edits-mega-thread/2164971

Thanks!

@github-actions github-actions bot added the changes requested This pull request has changes requested prior to merging label May 14, 2025
IgnisRBX
IgnisRBX previously approved these changes May 15, 2025
rbxphogen
rbxphogen previously approved these changes May 15, 2025
@IgnisRBX IgnisRBX merged commit 0c8b0f0 into Roblox:main May 15, 2025
3 checks passed
@karl-police karl-police deleted the patch-4 branch May 15, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested This pull request has changes requested prior to merging engine reference Changes the Engine API Reference documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants