Skip to content

Fix Sandboxed reference in AssetService docs#1452

Closed
secret-rare wants to merge 2 commits intoRoblox:mainfrom
secret-rare:assetservice-sandboxed-patch-1
Closed

Fix Sandboxed reference in AssetService docs#1452
secret-rare wants to merge 2 commits intoRoblox:mainfrom
secret-rare:assetservice-sandboxed-patch-1

Conversation

@secret-rare
Copy link

AssetService:LoadAssetAsync links to the non-existent Class.Model.Sandboxed Sandboxed is a property of Instance, not Model.

Changes

Change reference to Class.Model.Sandboxed to Class.Instance.Sandboxed

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

`Sandboxed` is a property of `Instance`, not `Model`.
@secret-rare secret-rare requested a review from a team as a code owner February 23, 2026 22:54
@github-actions github-actions bot added the engine reference Changes the Engine API Reference documentation label Feb 23, 2026
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @secret-rare, thanks so much for helping improve the Roblox creator documentation! Our technical writing team will review your pull request soon. In the meantime, please ensure you've read through the README.md, contribution guidelines, and style recommendations.

@aetter
Copy link
Contributor

aetter commented Feb 27, 2026

Hey secret-rare, thanks for the PR. I'm inclined to keep this one as-is since Model inherits from Instance. I get that the property description on Instance is the helpful one, but I feel like it opens a can of worms to link to the base class rather than the class in question, especially in situations where 2-3 inherited classes are involved. Thanks again!

@aetter aetter closed this Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine reference Changes the Engine API Reference documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants