Fix Sandboxed reference in AssetService docs#1452
Closed
secret-rare wants to merge 2 commits intoRoblox:mainfrom
Closed
Fix Sandboxed reference in AssetService docs#1452secret-rare wants to merge 2 commits intoRoblox:mainfrom
secret-rare wants to merge 2 commits intoRoblox:mainfrom
Conversation
`Sandboxed` is a property of `Instance`, not `Model`.
There was a problem hiding this comment.
Hi @secret-rare, thanks so much for helping improve the Roblox creator documentation! Our technical writing team will review your pull request soon. In the meantime, please ensure you've read through the README.md, contribution guidelines, and style recommendations.
Contributor
|
Hey secret-rare, thanks for the PR. I'm inclined to keep this one as-is since Model inherits from Instance. I get that the property description on Instance is the helpful one, but I feel like it opens a can of worms to link to the base class rather than the class in question, especially in situations where 2-3 inherited classes are involved. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AssetService:LoadAssetAsynclinks to the non-existentClass.Model.SandboxedSandboxedis a property ofInstance, notModel.Changes
Change reference to
Class.Model.SandboxedtoClass.Instance.SandboxedChecks
By submitting your pull request for review, you agree to the following: