Patch rosidl to add missing cstdint include#350
Merged
traversaro merged 3 commits intoRoboStack:mainfrom Sep 18, 2025
Merged
Conversation
Contributor
|
You also need to bump the version number as for example in https://github.com/noahjutz/ros-humble/blob/6eb47fb8d11aa7da8873147d84c86970639e9648/pkg_additional_info.yaml#L148 |
Member
|
@noahjutz we should document definitely this better, but basically all robostack packages share the same build number, that is set globally in https://github.com/RoboStack/ros-humble/blob/main/vinca.yaml#L9 (and is raise at full rebuild/sync). So currently the latest rosidl package has build number 13, to ensure that a newly built package is installed instead of the old one, it needs to have build number 14 . TL;DR: Use 14 instead of 1 |
Tobias-Fischer
approved these changes
Sep 18, 2025
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #349