Skip to content

Enable as2-cli in ROS Humble#357

Merged
traversaro merged 3 commits intoRoboStack:mainfrom
alvgaona:as2-cli-package
Oct 28, 2025
Merged

Enable as2-cli in ROS Humble#357
traversaro merged 3 commits intoRoboStack:mainfrom
alvgaona:as2-cli-package

Conversation

@alvgaona
Copy link
Contributor

@alvgaona alvgaona commented Oct 28, 2025

At aerostack we're slowly starting to enable AS2 packages in all of the platforms. This is the simplest and most straightforward package to enable.

Hopefully it works in the CI 🙏🏻

@traversaro
Copy link
Member

Thanks @alvgaona ! That is good to me, but just to let you know while the Windows package builds fine, it install just bash activation/scripts, so the command installed would not work on Windows. Just to understand, are you interested on Windows or not? Perhaps if you are not interested in Windows it could make more sense to only build packages on non-Windows platform?

@alvgaona
Copy link
Contributor Author

alvgaona commented Oct 28, 2025

Thanks @alvgaona ! That is good to me, but just to let you know while the Windows package builds fine, it install just bash activation/scripts, so the command installed would not work on Windows. Just to understand, are you interested on Windows or not? Perhaps if you are not interested in Windows it could make more sense to only build packages on non-Windows platform?

Yes @traversaro. It makes compelete sense. Let's start with non-win and non-wasm envs. I'll update the branch.

@traversaro
Copy link
Member

Thanks @alvgaona ! That is good to me, but just to let you know while the Windows package builds fine, it install just bash activation/scripts, so the command installed would not work on Windows. Just to understand, are you interested on Windows or not? Perhaps if you are not interested in Windows it could make more sense to only build packages on non-Windows platform?

Yes @traversaro. It makes compelete sense. Let's start with non-win and non-wasm envs. I'll update the branch.

Thanks! Just to clarify if you think it make sense to package it on Windows (as it is a dependency of other software, that will work on Windows) feel free to do so, I was just double checking.

@alvgaona
Copy link
Contributor Author

Thanks @alvgaona ! That is good to me, but just to let you know while the Windows package builds fine, it install just bash activation/scripts, so the command installed would not work on Windows. Just to understand, are you interested on Windows or not? Perhaps if you are not interested in Windows it could make more sense to only build packages on non-Windows platform?

Yes @traversaro. It makes compelete sense. Let's start with non-win and non-wasm envs. I'll update the branch.

Thanks! Just to clarify if you think it make sense to package it on Windows (as it is a dependency of other software, that will work on Windows) feel free to do so, I was just double checking.

I'd rather go carefully at this moment, I'll probably look into win in the next phase.

@traversaro
Copy link
Member

Thanks!

@traversaro traversaro merged commit 3b5ddd4 into RoboStack:main Oct 28, 2025
6 checks passed
@alvgaona alvgaona deleted the as2-cli-package branch October 28, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants