-
-
Notifications
You must be signed in to change notification settings - Fork 70
Add lbr_fri_ros2_stack #385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kenichi-maeda
wants to merge
10
commits into
RoboStack:main
Choose a base branch
from
kenichi-maeda:add-lbr-fri
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8a5e975
Add basic support for lbr-fri
kenichi-maeda 7945ef3
Use lbr-fri-client-sdk from conda-forge
kenichi-maeda adcb8e5
Add support for different FRI versions
kenichi-maeda 87bd48b
Remove host and run
kenichi-maeda 1b379be
Merge branch 'RoboStack:main' into add-lbr-fri
kenichi-maeda 2dfdaa4
Exclude fri 2.5 and 2.7
kenichi-maeda bb75ead
Fix kinematics-interface for win
kenichi-maeda 5fd24e0
Unpin lbr-fri-client-sdk
kenichi-maeda 4e0b94d
Clean up dependencies
kenichi-maeda f01d9ab
Fix win patch
kenichi-maeda File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -61,3 +61,10 @@ libzenohcxx: | |
| - 1.4.0 | ||
| libcap: | ||
| - 2.71 | ||
|
|
||
| lbr_fri_client_sdk: | ||
| - '1.11' | ||
| - '1.14' | ||
| - '1.15' | ||
| - '1.16' | ||
| - '1.17' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
| diff --git a/kinematics_interface/CMakeLists.txt b/kinematics_interface/CMakeLists.txt | ||
| index 27a6269..06549d9 100644 | ||
| --- a/CMakeLists.txt | ||
| +++ b/CMakeLists.txt | ||
| --- a/kinematics_interface/CMakeLists.txt | ||
| +++ b/kinematics_interface/CMakeLists.txt | ||
| @@ -45,5 +45,5 @@ install( | ||
| ) | ||
|
|
||
| ament_export_targets(export_kinematics_interface HAS_LIBRARY_TARGET) | ||
| -ament_export_dependencies(${THIS_PACKAGE_INCLUDE_DEPENDS}) | ||
| +ament_export_dependencies(${THIS_PACKAGE_INCLUDE_DEPENDS} Eigen3) | ||
| ament_package() | ||
| ament_package() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need any of the
lbr-fri-client-sdkpinnings, that should be taken care of in thelbr-fri-client-sdkfeedstocks by properly defining therun_exportsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing it out. I updated the yaml file.