Skip to content

Actually use snapshot, rebuild ros-noetic-desktop and ros-noetic-desktop-full with tests and remove rqt_web and webkit_dependency from rqt_common_plugins dependencies#506

Merged
Tobias-Fischer merged 6 commits intoRoboStack:mainfrom
traversaro:fixdesktop2025pkgs
Mar 3, 2025

Conversation

@traversaro
Copy link
Member

@traversaro traversaro commented Feb 25, 2025

This PR fixes #505 by dropping the rqt_web and webkit_dependency from rqt_common_plugins dependencies.

@traversaro
Copy link
Member Author

@traversaro
Copy link
Member Author

In https://github.com/RoboStack/ros-noetic/actions/runs/13533096802/job/37819480847?pr=506 I reproduced the error of #505 .

While in 0ab6c27 I tried to fix it, but there are still problems. Not sure if a full rebuild is necessary, but I am a bit out of time to check this out.

@traversaro
Copy link
Member Author

traversaro commented Feb 25, 2025

Perhaps it is a good idea to just do a full rebuild, without updating the snapshot.

@traversaro
Copy link
Member Author

Perhaps it is a good idea to just do a full rebuild, without updating the snapshot.

I attempted one in #507 .

@traversaro traversaro changed the title Actually use snapshot and rebuild ros-noetic-desktop with tests Actually use snapshot, rebuild ros-noetic-desktop with tests and remove rqt_web and webkit_dependency from rqt_common_plugins dependencies Feb 26, 2025
@traversaro
Copy link
Member Author

fyi @TedVanderfeen

@traversaro traversaro changed the title Actually use snapshot, rebuild ros-noetic-desktop with tests and remove rqt_web and webkit_dependency from rqt_common_plugins dependencies Actually use snapshot, rebuild ros-noetic-desktop and ros-noetic-desktop-full with tests and remove rqt_web and webkit_dependency from rqt_common_plugins dependencies Feb 26, 2025
@traversaro
Copy link
Member Author

@Tobias-Fischer @wolfv do you have any specific opinion on dropping rqt_web and webkin_dependency ?

@Tobias-Fischer
Copy link
Collaborator

It’s fine with me - we should take a note to remove the workaround once conda-forge has been updated?

@traversaro
Copy link
Member Author

It’s fine with me - we should take a note to remove the workaround once conda-forge has been updated?

I added an issue in #509 .

@Tobias-Fischer Tobias-Fischer merged commit 509ba72 into RoboStack:main Mar 3, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ros-noetic-desktop can't be installed with ros-distro-mutex==0.6.*

2 participants