Skip to content

fix: fish replacements#542

Merged
Tobias-Fischer merged 2 commits intoRoboStack:mainfrom
daenny:fix/fish
Aug 20, 2025
Merged

fix: fish replacements#542
Tobias-Fischer merged 2 commits intoRoboStack:mainfrom
daenny:fix/fish

Conversation

@daenny
Copy link
Contributor

@daenny daenny commented Aug 18, 2025

No description provided.

@traversaro
Copy link
Member

You also need to bump the build number of rosbash to ensure that a new package is built.

@daenny
Copy link
Contributor Author

daenny commented Aug 18, 2025

Okay, fish needed something different:

fish itself doesn’t evaluate this regex, find/_rosfind does, so the lookahead (?!) will only work if _rosfind supports PCRE.
image

@Tobias-Fischer
Copy link
Collaborator

Is this ready for review/merge? I assume you checked that it works in bash?

@daenny
Copy link
Contributor Author

daenny commented Aug 20, 2025

Yes, I checked fish locally, I did not change the bash completions as the other approach worked already.

@Tobias-Fischer
Copy link
Collaborator

Thanks a lot!!

@Tobias-Fischer Tobias-Fischer merged commit 5855e85 into RoboStack:main Aug 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants