[CMake Examples] Update required CMake versions #384
Conversation
There was a problem hiding this comment.
Successful CI corresponding with Drake #22898: https://drake-jenkins.csail.mit.edu/job/linux-jammy-unprovisioned-external-examples/3/.
+@BetsyMcPhail for feature review, please
Reviewable status: all discussions resolved, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @BetsyMcPhail)
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all discussions resolved, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @tyler-yankee)
There was a problem hiding this comment.
Reviewable status: all discussions resolved, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @tyler-yankee)
There was a problem hiding this comment.
+@ggould-tri for platform review Tuesday, per schedule
Reviewable status: all discussions resolved, LGTM missing from assignee betsymcphail, LGTM missing from assignee ggould-tri, platform LGTM missing (waiting on @ggould-tri)
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all discussions resolved, LGTM missing from assignee ggould-tri, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @tyler-yankee)
There was a problem hiding this comment.
Reviewable status: all discussions resolved, LGTM missing from assignee betsymcphail, platform LGTM from [ggould-tri] (waiting on @tyler-yankee)
There was a problem hiding this comment.
Blocked from merging until we resolve some discussions on the Drake PR -- TL;DR building Drake and consuming Drake require different minimum versions of CMake, so drake_cmake_installed and drake_cmake_installed_apt may be subject to change.
Reviewable status: all discussions resolved, LGTM missing from assignee betsymcphail, platform LGTM from [ggould-tri] (waiting on @tyler-yankee)
There was a problem hiding this comment.
Reviewable status: all discussions resolved, LGTM missing from assignee betsymcphail, platform LGTM from [ggould-tri] (waiting on @tyler-yankee)
tyler-yankee
changed the title
|
Okay, the examples are updated after discussion on #22898; essentially, we want to require 3.22 only for building Drake from source, while a lower version range is supported when consuming a binary Drake. We can also get rid of the manual policy adjustment that I wrote before by giving a maximum version to |
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: all discussions resolved, LGTM missing from assignee betsymcphail, platform LGTM from [ggould-tri] (waiting on @tyler-yankee)
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all discussions resolved, platform LGTM from [ggould-tri, betsymcphail] (waiting on @tyler-yankee)
Closes #22889.
drake_cmake_externalto use CMake 3.22...4.0 in accordance with https://drake.mit.edu/from_source.html (as of writing) while allowing for modern policies.drake_cmake_installedanddrake_cmake_installed_aptto use CMake 3.9...4.0, as consuming binary Drake does not require modern CMake, but we'll allow modern policies (and get rid of deprecation warnings about older versions when using newer ones).This change is