[drake_cmake_external] Update spdlog and fmt to match Drake's source #387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyler-yankee
changed the title
|
Note the Jenkins CI failure is expected; I actually canceled the build. The one to look at is here, which uses the aforementioned Drake PR containing the logic to support the newer version of spdlog. |
tyler-yankee
added
status: not ready to merge
and removed
status: not ready to merge
labels
|
+@BetsyMcPhail for feature review, please. |
|
CI is now happy, as the supporting Drake PR is merged; comment above can be ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #385, with supporting logic from Drake from #22915.
fmtto 11.0.2.spdlogto 1.15.0.This change is