Upgrade to OnePassword 2.30.0 #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerickson14
requested review from
rnp-bradpf
and removed request for
rnp-bradpf
aerickson14
force-pushed
the
onepassword-upgrade
branch
27 times, most recently
from
e6b7cd3 to
6645cdd
Compare
aerickson14
force-pushed
the
onepassword-upgrade
branch
12 times, most recently
from
86c1a70 to
1f564a6
Compare
aerickson14
force-pushed
the
onepassword-upgrade
branch
from
1f564a6 to
5c44234
Compare
rnp-bradpf
approved these changes
Oct 16, 2024
|
|
||
| let extracted: string | ||
| if (platform === 'darwin') { |
There was a problem hiding this comment.
Question: Does this mean we are no longer verifying the binary on MacOS? I assume the action itself still functions as expected on the darwin platform?
There was a problem hiding this comment.
I had to switch to using the .zip file because the .pkg no longer has a /Payload file given that the pkg version is now a (Mac) universal distribution.
I spent some time trying to figure out if we could still do verification on the zip file but wasn't able to find a solution. If in the future we are able to do this type of verification it would be great to add it back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently this action is failing trying to sign in. After some investigation, it seems version 1.x has been deprecated and that version is not expected to work after October 1, 2024.
Following the migration guide this action was updated to use version
2.30.0of the OnePassword CLI and the api endpoint names were updated to use the new format.npm run packagewas run to create the new distribution andnpm testwas run to verify tests pass.Once this PR has been approved and merged we can add a git tags
v3.0.0and3.0.0so that projects can update to use this new version.Did you update the Changelog?