feat: support afp:// links and open them with system handler#3249
Open
Ram-sah19 wants to merge 1 commit intoRocketChat:developfrom
Open
feat: support afp:// links and open them with system handler#3249Ram-sah19 wants to merge 1 commit intoRocketChat:developfrom
Ram-sah19 wants to merge 1 commit intoRocketChat:developfrom
Conversation
Contributor
|
Caution Review failedFailed to post review comments WalkthroughThis pull request introduces enhanced initialization and lifecycle management for the main Electron application, adds crash recovery and error handling to window management, updates CI/CD workflows for snap packaging and ARM64 support, adds Hungarian translation keys, and temporarily downgrades electron-builder while removing flatpak from Linux packaging targets. Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~50 minutes Suggested labels
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for afp:// links in the Rocket.Chat desktop client.
Previously AFP links were opened in the browser.
With this change, AFP links are opened using the system handler (e.g., Finder on macOS).
Fixes issue where AFP file paths could not be opened directly from chat messages.
Summary by CodeRabbit
New Features
Improvements
Platform Support
Localization
fix issue #438