Skip to content

Conversation

@OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Apr 7, 2025

Proposed changes

Create inline error on avatar url input in newServerView.

Issue(s)

https://rocketchat.atlassian.net/browse/MA-235

How to test or reproduce

  • Open the app (newServerView);
  • Fill "Workspace URL" input with invalid url;
  • Press "Connect" button;

Screenshots

Before After
Simulator Screenshot - iPhone 16 - 2025-07-02 at 15 19 27 Simulator Screenshot - iPhone 16 - 2025-07-02 at 15 19 09

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@OtavioStasiak OtavioStasiak changed the title Feat a11y inline error new server view feat(a11y): inline error on newServerView Apr 7, 2025
Copy link
Member

@diegolmello diegolmello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a huge refactor to function components and the inline error.
I think we should split this PR into two.

@OtavioStasiak OtavioStasiak changed the title feat(a11y): inline error on newServerView feat(a11y): inline errors newServerView Jun 18, 2025
@OtavioStasiak OtavioStasiak marked this pull request as ready for review July 2, 2025 18:24
@OtavioStasiak OtavioStasiak merged commit a18fbd4 into develop Jul 9, 2025
6 of 11 checks passed
@OtavioStasiak OtavioStasiak deleted the feat-a11y-inline-error-new-server-view branch July 9, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants