Skip to content

fix: normalize MIME type to lowercase before upload validation #7147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepak0x wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: normalize MIME type to lowercase before upload validation #7147

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e2e795
fix: normalize MIME type to lowercase before upload validation
deepak0x Apr 13, 2026
2067983
fix: normalize MIME once and guard against undefined
deepak0x Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/lib/methods/helpers/media.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,12 @@ export const canUploadFile = ({
return { success: true };
}
const allowedMime = allowList.replaceAll(' ', '').split(',');
if (allowedMime.includes(file.mime!)) {
if (allowedMime.includes(file.mime!.toLowerCase())) {
return { success: true };
}
const wildCardGlob = '/*';
const wildCards = allowedMime.filter((item: string) => item.indexOf(wildCardGlob) > 0);
if (file.mime && wildCards.includes(file.mime.replace(/(\/.*)$/, wildCardGlob))) {
if (file.mime && wildCards.includes(file.mime.toLowerCase().replace(/(\/.*)$/, wildCardGlob))) {
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated
return { success: true };
}
return { success: false, error: 'error-invalid-file-type' };
Expand Down