-
Notifications
You must be signed in to change notification settings - Fork 11.7k
feat: keyboard navigation on notification preferences contextual bar #35901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
🦋 Changeset detectedLatest commit: a4631d3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
...teor/client/views/room/contextualBar/NotificationPreferences/NotificationPreferencesForm.tsx
Outdated
Show resolved
Hide resolved
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35901 +/- ##
========================================
Coverage 61.18% 61.18%
========================================
Files 3157 3161 +4
Lines 74670 74701 +31
Branches 16677 16678 +1
========================================
+ Hits 45687 45708 +21
- Misses 25879 25895 +16
+ Partials 3104 3098 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
apps/meteor/client/views/room/contextualBar/NotificationPreferences/NotificationPreferences.tsx
Outdated
Show resolved
Hide resolved
...or/client/views/room/contextualBar/NotificationPreferences/components/NotificationToggle.tsx
Outdated
Show resolved
Hide resolved
...or/client/views/room/contextualBar/NotificationPreferences/components/NotificationToggle.tsx
Outdated
Show resolved
Hide resolved
...or/client/views/room/contextualBar/NotificationPreferences/components/NotificationToggle.tsx
Outdated
Show resolved
Hide resolved
Kody Review CompleteGreat news! 🎉 Keep up the excellent work! 🚀 Kody Guide: Usage and ConfigurationInteracting with Kody
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
|
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
This pull request introduces enhancements to the keyboard navigation within the notification preferences contextual bar in the Rocket.Chat application. The changes include:
FocusScope
component fromreact-aria
in theNotificationPreferences.tsx
file to improve focus management.NotificationPreferencesForm.tsx
file to enhance accessibility.autoFocus
prop to theNotificationToggle.tsx
component to improve user experience.These updates aim to provide a more accessible and user-friendly interface for managing notification preferences.
SIDE2-64