fix: align moderation console skeleton columns with header#38716
fix: align moderation console skeleton columns with header#38716ScriptShah wants to merge 1 commit intoRocketChat:developfrom
Conversation
|
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
WalkthroughThe ModerationConsoleTable loading skeleton now uses the actual header array length instead of a hardcoded value of 6, ensuring the skeleton column count matches the rendered table header count and prevents UI misalignment during the loading state. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #38716 +/- ##
===========================================
- Coverage 70.49% 70.47% -0.02%
===========================================
Files 3175 3175
Lines 111094 111094
Branches 20045 20017 -28
===========================================
- Hits 78311 78292 -19
- Misses 30738 30750 +12
- Partials 2045 2052 +7
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
This PR fixes a UI inconsistency in Admin → Moderation → Console where the loading skeleton renders a different number of columns than the table header.
Previously, the skeleton used a hardcoded value:
However, the table header dynamically renders 5 columns, causing a visible layout shift and misalignment during loading.
This PR replaces the hardcoded value with the actual header length:
This ensures the loading skeleton always matches the number of header columns and prevents UI misalignment.
📸 Screenshots :
This is a minimal and safe change with no behavioral impact beyond correcting the loading state layout.
Issue(s)
Fixes #38714
Steps to test or reproduce
Before fix:
After fix:
Further comments
This is a small UI consistency fix that improves the perceived quality of the Admin console loading state.
No changeset is included as this does not introduce a user-facing feature or require a version bump.
Summary by CodeRabbit