Conversation
4f83cc6 to
7995f92
Compare
|
|
||
| // PortmasterRecnciler emulates the cli through steps that needs be performed for the directed mode. | ||
| // hides the details of k8s api. | ||
| type PortmasterRecnciler interface { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant improvements to local development and testing workflows, particularly around k3d-based Kubernetes environments, and adds new Kubernetes API types for MongoDB backups. The most important changes are the addition of comprehensive k3d Makefile targets and documentation, the introduction of a new
MongoDBBackupCRD, and updates to the build and test processes.Local Development & Testing Enhancements:
kubectldirectly against the cluster. This enables reproducible, scriptable local development and testing environments.README.md: Documents all Makefile targets for k3d cluster management, deployment, image handling, and common workflows, making it much easier for developers to set up, test, and debug locally.Kubernetes API Additions:
MongoDBBackupCustom Resource Definition: IntroducesMongoDBBackupand related types, including phases, conditions, and status structures. Also defines rules for phase transitions using conditions, supporting robust backup state management in the operator.Object2interface: Defines a new interface in the API for objects that track phase and observed generation, enabling generic controller logic.Build & Test Process Improvements:
CONTROLLER_TOOLS_VERSION: Updates to a newer version for controller tools, likely for compatibility and bug fixes.CI/CD Workflow:
nolar/setup-k3d-k3swithRocketChat/k3d-with-registry@mainfor improved or customized k3d cluster setup in CI.Local development & testing:
README.md, providing step-by-step instructions for local development and testing.Kubernetes API/CRD:
MongoDBBackupCRD and supporting types, including phase/condition management and status fields, to support backup orchestration in the operator.Object2interface for phase and observed generation tracking in API objects.Build & CI improvements: