fix(stories): update Box stories to correctly render colors and layouts#1732
Closed
Aryan9inja wants to merge 1 commit intoRocketChat:mainfrom
Closed
fix(stories): update Box stories to correctly render colors and layouts#1732Aryan9inja wants to merge 1 commit intoRocketChat:mainfrom
Aryan9inja wants to merge 1 commit intoRocketChat:mainfrom
Conversation
|
|
Contributor
Author
|
@aleksandernsilva Can you pls review this bug fix. |
Contributor
|
Thankyou for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
bg='light',bg='tint', etc.) in the Box stories.Video proof of issue fix-
Recording.2025-07-30.151314.mp4
Issue(s)
Closes #1695
Further comments
Used
SurfaceContext.Providerto ensure background color tokens are interpreted correctly when renderingBoxvariants. Considered alternatives like hardcoded background colors but chose context to align with design token usage across Fuselage.