Skip to content

fix(fuselage): SidebarV2Item padding #1744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 3 commits into from
Aug 28, 2025
Merged

fix(fuselage): SidebarV2Item padding #1744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
82a0b91
fix: SidebarItem padding
dougfabris Aug 28, 2025
25b6fd7
chore: changeset
dougfabris Aug 28, 2025
25fdfd1
chore: update snapshot
dougfabris Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/four-baboons-float.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/fuselage': patch
---

fix(fuselage): SidebarV2Item padding
4 changes: 4 additions & 0 deletions packages/fuselage/src/components/SidebarV2/SidebarItem/SidebarItem.styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ $sidebar-color-font-active: theme(
text-decoration: none;
gap: lengths.padding(4);

&--level-2 {
padding-block: calc(lengths.padding(8) - lengths.border-width('default'));
}

&:active {
color: $sidebar-color-font-active;
}
Expand Down
3 changes: 3 additions & 0 deletions packages/fuselage/src/components/SidebarV2/SidebarItem/SidebarItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,21 @@ import type { AllHTMLAttributes } from 'react';

export const SidebarItem = ({
selected,
level = 1,
className,
children,
is: Tag = 'a',
...props
}: {
selected?: boolean;
level?: number;
is?: React.ElementType;
} & AllHTMLAttributes<HTMLAnchorElement>) => (
<Tag
className={[
'rcx-box rcx-box--full rcx-sidebar-v2-item',
selected && 'rcx-sidebar-v2-item--selected',
level && `rcx-sidebar-v2-item--level-${level}`,
className,
]
.filter(Boolean)
Expand Down
2 changes: 1 addition & 1 deletion packages/fuselage/src/components/Sidepanel/Sidepanel.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ const Template: StoryFn<typeof Sidepanel> = (args) => (
{new Array(20).fill(null).map((_, index) => {
return (
<SidepanelListItem key={index}>
<SidebarV2Item href='#'>
<SidebarV2Item level={2} href='#'>
<SidebarV2ItemCol>
<SidebarV2ItemRow>
<SidebarItemAvatarWrapper>
Expand Down
4 changes: 0 additions & 4 deletions packages/fuselage/src/components/Sidepanel/Sidepanel.styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,5 @@ $sidepanel-color-default: colors.font(default);

&-list {
padding-block: lengths.padding(8);

&__item {
padding-block: lengths.padding(4);
}
}
}
40 changes: 20 additions & 20 deletions packages/fuselage/src/components/Sidepanel/__snapshots__/Sidepanel.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ exports[`renders Default without crashing 1`] = `
role="listitem"
>
<a
class="rcx-box rcx-box--full rcx-sidebar-v2-item"
class="rcx-box rcx-box--full rcx-sidebar-v2-item rcx-sidebar-v2-item--level-2"
href="#"
>
<div
Expand Down Expand Up @@ -179,7 +179,7 @@ exports[`renders Default without crashing 1`] = `
role="listitem"
>
<a
class="rcx-box rcx-box--full rcx-sidebar-v2-item"
class="rcx-box rcx-box--full rcx-sidebar-v2-item rcx-sidebar-v2-item--level-2"
href="#"
>
<div
Expand Down Expand Up @@ -285,7 +285,7 @@ exports[`renders Default without crashing 1`] = `
role="listitem"
>
<a
class="rcx-box rcx-box--full rcx-sidebar-v2-item"
class="rcx-box rcx-box--full rcx-sidebar-v2-item rcx-sidebar-v2-item--level-2"
href="#"
>
<div
Expand Down Expand Up @@ -391,7 +391,7 @@ exports[`renders Default without crashing 1`] = `
role="listitem"
>
<a
class="rcx-box rcx-box--full rcx-sidebar-v2-item"
class="rcx-box rcx-box--full rcx-sidebar-v2-item rcx-sidebar-v2-item--level-2"
href="#"
>
<div
Expand Down Expand Up @@ -497,7 +497,7 @@ exports[`renders Default without crashing 1`] = `
role="listitem"
>
<a
class="rcx-box rcx-box--full rcx-sidebar-v2-item"
class="rcx-box rcx-box--full rcx-sidebar-v2-item rcx-sidebar-v2-item--level-2"
href="#"
>
<div
Expand Down Expand Up @@ -603,7 +603,7 @@ exports[`renders Default without crashing 1`] = `
role="listitem"
>
<a
class="rcx-box rcx-box--full rcx-sidebar-v2-item"
class="rcx-box rcx-box--full rcx-sidebar-v2-item rcx-sidebar-v2-item--level-2"
href="#"
>
<div
Expand Down Expand Up @@ -709,7 +709,7 @@ exports[`renders Default without crashing 1`] = `
role="listitem"
>
<a
class="rcx-box rcx-box--full rcx-sidebar-v2-item"
class="rcx-box rcx-box--full rcx-sidebar-v2-item rcx-sidebar-v2-item--level-2"
href="#"
>
<div
Expand Down Expand Up @@ -815,7 +815,7 @@ exports[`renders Default without crashing 1`] = `
role="listitem"
>
<a
class="rcx-box rcx-box--full rcx-sidebar-v2-item"
class="rcx-box rcx-box--full rcx-sidebar-v2-item rcx-sidebar-v2-item--level-2"
href="#"
>
<div
Expand Down Expand Up @@ -921,7 +921,7 @@ exports[`renders Default without crashing 1`] = `
role="listitem"
>
<a
class="rcx-box rcx-box--full rcx-sidebar-v2-item"
class="rcx-box rcx-box--full rcx-sidebar-v2-item rcx-sidebar-v2-item--level-2"
href="#"
>
<div
Expand Down Expand Up @@ -1027,7 +1027,7 @@ exports[`renders Default without crashing 1`] = `
role="listitem"
>
<a
class="rcx-box rcx-box--full rcx-sidebar-v2-item"
class="rcx-box rcx-box--full rcx-sidebar-v2-item rcx-sidebar-v2-item--level-2"
href="#"
>
<div
Expand Down Expand Up @@ -1133,7 +1133,7 @@ exports[`renders Default without crashing 1`] = `
role="listitem"
>
<a
class="rcx-box rcx-box--full rcx-sidebar-v2-item"
class="rcx-box rcx-box--full rcx-sidebar-v2-item rcx-sidebar-v2-item--level-2"
href="#"
>
<div
Expand Down Expand Up @@ -1239,7 +1239,7 @@ exports[`renders Default without crashing 1`] = `
role="listitem"
>
<a
class="rcx-box rcx-box--full rcx-sidebar-v2-item"
class="rcx-box rcx-box--full rcx-sidebar-v2-item rcx-sidebar-v2-item--level-2"
href="#"
>
<div
Expand Down Expand Up @@ -1345,7 +1345,7 @@ exports[`renders Default without crashing 1`] = `
role="listitem"
>
<a
class="rcx-box rcx-box--full rcx-sidebar-v2-item"
class="rcx-box rcx-box--full rcx-sidebar-v2-item rcx-sidebar-v2-item--level-2"
href="#"
>
<div
Expand Down Expand Up @@ -1451,7 +1451,7 @@ exports[`renders Default without crashing 1`] = `
role="listitem"
>
<a
class="rcx-box rcx-box--full rcx-sidebar-v2-item"
class="rcx-box rcx-box--full rcx-sidebar-v2-item rcx-sidebar-v2-item--level-2"
href="#"
>
<div
Expand Down Expand Up @@ -1557,7 +1557,7 @@ exports[`renders Default without crashing 1`] = `
role="listitem"
>
<a
class="rcx-box rcx-box--full rcx-sidebar-v2-item"
class="rcx-box rcx-box--full rcx-sidebar-v2-item rcx-sidebar-v2-item--level-2"
href="#"
>
<div
Expand Down Expand Up @@ -1663,7 +1663,7 @@ exports[`renders Default without crashing 1`] = `
role="listitem"
>
<a
class="rcx-box rcx-box--full rcx-sidebar-v2-item"
class="rcx-box rcx-box--full rcx-sidebar-v2-item rcx-sidebar-v2-item--level-2"
href="#"
>
<div
Expand Down Expand Up @@ -1769,7 +1769,7 @@ exports[`renders Default without crashing 1`] = `
role="listitem"
>
<a
class="rcx-box rcx-box--full rcx-sidebar-v2-item"
class="rcx-box rcx-box--full rcx-sidebar-v2-item rcx-sidebar-v2-item--level-2"
href="#"
>
<div
Expand Down Expand Up @@ -1875,7 +1875,7 @@ exports[`renders Default without crashing 1`] = `
role="listitem"
>
<a
class="rcx-box rcx-box--full rcx-sidebar-v2-item"
class="rcx-box rcx-box--full rcx-sidebar-v2-item rcx-sidebar-v2-item--level-2"
href="#"
>
<div
Expand Down Expand Up @@ -1981,7 +1981,7 @@ exports[`renders Default without crashing 1`] = `
role="listitem"
>
<a
class="rcx-box rcx-box--full rcx-sidebar-v2-item"
class="rcx-box rcx-box--full rcx-sidebar-v2-item rcx-sidebar-v2-item--level-2"
href="#"
>
<div
Expand Down Expand Up @@ -2087,7 +2087,7 @@ exports[`renders Default without crashing 1`] = `
role="listitem"
>
<a
class="rcx-box rcx-box--full rcx-sidebar-v2-item"
class="rcx-box rcx-box--full rcx-sidebar-v2-item rcx-sidebar-v2-item--level-2"
href="#"
>
<div
Expand Down
Loading