Skip to content

fix(fuselage): Remove unsafe type casts in Select components #1895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Harshit2405-2004 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(fuselage): Remove unsafe type casts in Select components #1895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d62b43
fix(fuselage): remove unsafe value casts in Select components
Harshit2405-2004 Mar 6, 2026
71f8867
Merge branch 'main' into fix/select-type-safety
Harshit2405-2004 Mar 6, 2026
f1e9cb3
Merge branch 'main' into fix/select-type-safety
Harshit2405-2004 Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/select-types.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/fuselage': patch
---

Remove unsafe SelectOption casting and widen the value type to string | number.
2 changes: 1 addition & 1 deletion packages/fuselage/src/components/PaginatedSelect/PaginatedSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export const PaginatedSelect = ({

const internalChangedByClick = useStableCallback(([value]: OptionType) => {
setInternalValue(value);
onChange(value as SelectOption[0]); // FIXME
onChange(value); // FIXME
hide();
});

Expand Down
4 changes: 2 additions & 2 deletions packages/fuselage/src/components/Select/SelectLegacy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ const SelectLegacy = forwardRef<HTMLInputElement, SelectProps>(
const internalChangedByKeyboard = useStableCallback(
([value]: OptionType) => {
setInternalValue(value);
onChange(value as SelectOption[0]); // FIXME
onChange(value); // FIXME
},
);

Expand Down Expand Up @@ -121,7 +121,7 @@ const SelectLegacy = forwardRef<HTMLInputElement, SelectProps>(

const internalChangedByClick = useStableCallback(([value]: OptionType) => {
setInternalValue(value);
onChange(value as SelectOption[0]); // FIXME
onChange(value); // FIXME
removeFocusClass();
hide();
});
Expand Down