Skip to content

test(fuselage): Update stories incompatible with visual regression testing #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tassoevan merged 2 commits into from
Mar 11, 2026
Merged

test(fuselage): Update stories incompatible with visual regression testing #1899

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0374958
test(fuselage): Update stories incompatible with visual regression te…
tassoevan Mar 11, 2026
efe6056
fix: Menu import
gabriellsh Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/fuselage/src/components/Box/layout.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,9 @@ Insets.decorators = [
),
];

export const Invisible: StoryFn<typeof Box> = () => <Box invisible />;
export const Invisible: StoryFn<typeof Box> = () => (
<Box invisible>Invisible</Box>
);

export const Margins: StoryFn<typeof Box> = () => (
<>
Expand Down
22 changes: 5 additions & 17 deletions packages/fuselage/src/components/SidebarV2/helpers.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import type { Decorator } from '@storybook/react-webpack5';

import { Menu, MenuItem } from '../..';
import { MenuV2 as Menu, MenuItem } from '../..';
import { Avatar } from '../Avatar';
import { Box } from '../Box';
import { IconButton } from '../Button';
Expand Down Expand Up @@ -68,10 +68,7 @@ export const GenericCondensedItem = ({ i = 0 }: { i: number }) => (
{names[i % 10]}
</SidebarV2ItemTitle>
{i % 2 !== 0 && (
<SidebarV2ItemBadge
title='unread messages'
children={Math.floor(Math.random() * 10) + 1}
/>
<SidebarV2ItemBadge title='unread messages' children={5} />
)}
{i === 0 && (
<SidebarV2Actions>
Expand All @@ -95,10 +92,7 @@ export const GenericNoAvatarItem = ({ i = 0 }: { i: number }) => (
<SidebarV2Item href='#'>
<SidebarV2ItemStatusBullet status='online' />
<SidebarV2ItemTitle>{names[i % 10]}</SidebarV2ItemTitle>
<SidebarV2ItemBadge
title='unread messages'
children={Math.floor(Math.random() * 10) + 1}
/>
<SidebarV2ItemBadge title='unread messages' children={5} />
<SidebarV2ItemMenu children={<MenuTemplate />} />
</SidebarV2Item>
</SidebarV2ListItem>
Expand All @@ -112,10 +106,7 @@ export const GenericMediumItem = ({ i = 0 }: { i: number }) => (
</SidebarV2ItemAvatarWrapper>
<SidebarV2ItemIcon icon='team' />
<SidebarV2ItemTitle>{names[i % 10]}</SidebarV2ItemTitle>
<SidebarV2ItemBadge
title='unread messages'
children={Math.floor(Math.random() * 10) + 1}
/>
<SidebarV2ItemBadge title='unread messages' children={5} />
<SidebarV2ItemMenu children={<MenuTemplate />} />
</SidebarV2Item>
</SidebarV2ListItem>
Expand All @@ -137,10 +128,7 @@ export const GenericExtendedItem = ({ i = 0 }: { i: number }) => (

<SidebarV2ItemRow>
<SidebarV2ItemContent>No messages yet</SidebarV2ItemContent>
<SidebarV2ItemBadge
title='unread messages'
children={Math.floor(Math.random() * 10) + 1}
/>
<SidebarV2ItemBadge title='unread messages' children={5} />
<SidebarV2ItemMenu children={<MenuTemplate />} />
</SidebarV2ItemRow>
</SidebarV2ItemCol>
Expand Down
Loading