You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The CheckBox component no longer supports the is prop (was previously inherited from Box).
Storybook still had a control for is, causing TypeScript errors and Storybook crashes.
Steps to Reproduce
Open Storybook for Inputs/CheckBox
Try to use the is control in Storybook
Observe TypeScript error:
type 'string' is not assignable to type 'ElementType | undefined'
Component still works, but Storybook shows errors and crashes when is is selected.
Solution
Removed is control from Storybook for CheckBox
Kept CheckBoxProps clean: Omit<BoxProps, 'is'>
Checkbox functionality remains unchanged
Storybook runs without error
Expected Behavior
No TypeScript errors
Storybook loads cleanly
CheckBox works normally
Actual Behavior
TypeScript error when passing is
Storybook crash or object showing instead of proper element
Backward-compatible fix
Tested manually in Storybook: Closes#1904
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You have signed the CLA already but the status is still pending? Let us recheck it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CheckBox component no longer supports the
isprop (was previously inherited from Box).Storybook still had a control for
is, causing TypeScript errors and Storybook crashes.Steps to Reproduce
iscontrol in Storybooktype 'string' is not assignable to type 'ElementType | undefined'
isis selected.Solution
iscontrol from Storybook for CheckBoxOmit<BoxProps, 'is'>Expected Behavior
Actual Behavior
isBackward-compatible fix

Tested manually in Storybook:
Closes #1904