Skip to content

bumps hubot version from 3 to 11 AND converts this to ESM#353

Open
BrunoMBento wants to merge 1 commit intoRocketChat:masterfrom
BrunoMBento:master
Open

bumps hubot version from 3 to 11 AND converts this to ESM#353
BrunoMBento wants to merge 1 commit intoRocketChat:masterfrom
BrunoMBento:master

Conversation

@BrunoMBento
Copy link

…converts this to ESM

@CLAassistant
Copy link

CLAassistant commented Jul 4, 2024

CLA assistant check
All committers have signed the CLA.

@BrunoMBento
Copy link
Author

Bumps hubot support from 3 to version 11. Hubot 11 changed hubot from CommonJS to ESM. Therefore, this pull request converts hubot-rocketchat to ESM and change the way the adapter is exported for compatibility.

@BrunoMBento BrunoMBento changed the title bumps hubot from 3 to version 11, and it's new Adapter interface AND … bumps hubot version from 3 to 11 AND converts this to ESM Jul 4, 2024
@fatcatt013
Copy link

2024-07-19 12:10:32.018	
{"level":20,"time":1721383831993,"pid":7,"hostname":"c752786e26e1","name":"hubot-dev","msg":"TextMessage: hi im matej"}
2024-07-19 12:10:32.018	
{"level":30,"time":1721383831993,"pid":7,"hostname":"c752786e26e1","name":"hubot-dev","msg":"Filters passed, will receive message"}

@BrunoMBento

I am using this script

// Description:
// 
//   Debug
// Dependencies:
// None
//
// Configuration:
// None
//
// Commands:
//   hubot debug

'use strict';

export default async robot => {
  robot.respond(/debug/i, async res => {
    res.reply(`Debugging CMD is working`);
  });

  robot.hear(/hey im matej/i, async res => {
    res.reply(`Hey im hubot`);
  })
}

Everything loads correctly

2024-07-19 12:09:23.854	
{"level":20,"time":1721383757040,"pid":7,"hostname":"c752786e26e1","name":"hubot-dev","msg":"Parsing help for /usr/local/lib/node_modules/hubot/src/scripts/debug.mjs"}

This loads fine.. and by "msg":"Filters passed, will receive message"} I think this means that the message should be sent, so the whole hubot part works fine.. but I don't get the rocketchat message.. everything seems to be working, just not this

It started happening after we upgraded to hubot@11 and we have replaced the hubot-rocketchat offical outdated repo with your PR.

Let me know if you need more info.. your insight would be really appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants