Open
Conversation
in that line when const user is defined...later props like roomID is defined as user.roomID.Means roomID is key of object user which is inside object envelope.So, i think this one should be envelope.user.room at line 146.
|
|
Author
|
Please review my pull request.I want to learn what have I done is effective or not. |
Author
|
hello maintainers ,please review whether my approach is right or not? |
Author
|
Hello maintainers ,I tried to fix the issue by updating an index file..please share whether its useful or not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in that line when const user is defined...later props like roomID is defined as user.roomID.Means roomID is key of object user which is inside object envelope.So, i think this one should be envelope.user.room at line 146.