Conversation
casalsgh
commented
Jun 22, 2023
| SubscriptionStatusCancelled SubscriptionStatus = "cancelled" //nolint:misspell //cancelled is how we spell it | ||
|
|
||
| // SubscriptionStatusCancelling is when the subscription is being canceled | ||
| SubscriptionStatusCancelling SubscriptionStatus = "cancelling" //nolint:misspell //cancelled is how we spell it |
There was a problem hiding this comment.
we might need to suppress this rule or it might need to remain a commend like this to keep linter from being unhappy about this
There was a problem hiding this comment.
I think I kept it, but still not able to pass the lint
There was a problem hiding this comment.
based on right below it seems to be gone
| SubscriptionStatusTrialing SubscriptionStatus = "trialing" | ||
| SubscriptionStatusActive SubscriptionStatus = "active" | ||
| SubscriptionStatusCancelled SubscriptionStatus = "cancelled" | ||
| SubscriptionStatusCancelling SubscriptionStatus = "cancelling" |
|
Coming back at this with fresh eyes. In general with this being public repo and there being the possibility of others consuming it and need to understand the various states.. I don't know that removing these comments is actually making anything better. I feel while its a bit easier to read.. in this case knowing what these states do its worth it having more comments Also if you look at go docs you can see a bit on how its useful: https://pkg.go.dev/github.com/RocketChat/marketplace-go@v1.2.1/events |