Further unpkg for jsdelivr by brothhammer · Pull Request #1381 · RocketCommunicationsInc/astro

brothhammer · 2025-04-04T20:23:19Z

Brief Description

unpkg has been unreliable. This PR switches this repo to jsdelivr

JIRA Link

https://rocketcom.atlassian.net/browse/AP-400?linkSource=email

Related Issue

This is the second PR for this change. The first was done to change the customer facing instructions.
#1378

General Notes

removed all commented out instances of unpkg
included screen shots of the script tags loading correctly

Motivation and Context

We want to be consistent and only rely on one package for ease of maintenance and reliability.

Issues and Limitations

Types of changes

Maintenance

Checklist

This PR adds or removes a Storybook story.
I have added tests to cover my changes.
Regressions are passing and/or failures are documented
Changes have been checked in evergreen browsers

changeset-bot · 2025-04-04T20:23:22Z

⚠️ No Changeset found

Latest commit: c7e3a7a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify · 2025-04-04T20:23:36Z

✅ Deploy Preview for astro-preview ready!

Name	Link
🔨 Latest commit	`47151ca`
🔍 Latest deploy log	https://app.netlify.com/sites/astro-preview/deploys/67f3ea518fe7e8000854a04a
😎 Deploy Preview	https://deploy-preview-1381--astro-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify · 2025-04-04T20:23:37Z

✅ Deploy Preview for astro-stencil ready!

Name	Link
🔨 Latest commit	`47151ca`
🔍 Latest deploy log	https://app.netlify.com/sites/astro-stencil/deploys/67f3ea51abedf40008fc71b0
😎 Deploy Preview	https://deploy-preview-1381--astro-stencil.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

brothhammer · 2025-04-04T20:25:07Z

.changeset/config.json

@@ -1,5 +1,5 @@
 {
-  "$schema": "https://unpkg.com/@changesets/config@1.6.3/schema.json",


The changeset command still works as expected. However VS code is mad about the URL. I tried clearing the VS code casche and restarting. Any other ideas?

packages/web-components/src/components/rux-status/test/index.html

brothhammer · 2025-04-07T15:13:39Z

packages/web-components/src/components/rux-status/test/index.html

-            src="https://unpkg.com/@rocketmark/figma-testing-library/dist/figma-testing-library/figma-testing-library.esm.js"
+            src="https://cdn.jsdelivr.net/npm/@rocketmark/figma-testing-library/dist/figma-testing-library/figma-testing-library.esm.js"
        ></script>
    </head>


brothhammer · 2025-04-07T15:21:51Z

packages/web-components/src/stories/astro-sandboxes/forms/html/index.html

            type="module"
-            src="https://unpkg.com/@astrouxds/astro-web-components/dist/astro-web-components/astro-web-components.esm.js"
+            src="https://cdn.jsdelivr.net/npm/@astrouxds/astro-web-components/dist/astro-web-components/astro-web-components.esm.js"
        ></script>


brothhammer · 2025-04-07T15:22:18Z

packages/web-components/src/stories/astro-sandboxes/forms/html/index.html

            rel="stylesheet"
-            href="https://unpkg.com/@astrouxds/astro-web-components/dist/astro-web-components/astro-web-components.css"
+            href="https://cdn.jsdelivr.net/npm/@astrouxds/astro-web-components/dist/astro-web-components/astro-web-components.css"
        />


brothhammer · 2025-04-07T15:24:41Z

packages/web-components/src/stories/astro-sandboxes/themes/ag-grid/index.html

            rel="stylesheet"
-            href="https://unpkg.com/@astrouxds/astro-web-components/dist/astro-web-components/astro-web-components.css"
+            href="https://cdn.jsdelivr.net/npm/@astrouxds/astro-web-components/dist/astro-web-components/astro-web-components.css"
        />


brothhammer · 2025-04-07T15:26:45Z

packages/web-components/src/stories/astro-sandboxes/forms/svelte/basic/public/index.html

            type="module"
-            src="https://unpkg.com/@astrouxds/astro-web-components/dist/astro-web-components/astro-web-components.esm.js"
+            src="https://cdn.jsdelivr.net/npm/@astrouxds/astro-web-components/dist/astro-web-components/astro-web-components.esm.js"
        ></script>


brothhammer · 2025-04-07T15:28:16Z

packages/web-components/src/stories/astro-sandboxes/forms/svelte/validation/public/index.html

            type="module"
-            src="https://unpkg.com/@astrouxds/astro-web-components/dist/astro-web-components/astro-web-components.esm.js"
+            src="https://cdn.jsdelivr.net/npm/@astrouxds/astro-web-components/dist/astro-web-components/astro-web-components.esm.js"
        ></script>


brothhammer · 2025-04-07T15:29:26Z

packages/web-components/src/stories/astro-sandboxes/sign-in/index.html

            type="module"
-            src="https://unpkg.com/@astrouxds/astro-web-components/dist/astro-web-components/astro-web-components.esm.js"
+            src="https://cdn.jsdelivr.net/npm/@astrouxds/astro-web-components/dist/astro-web-components/astro-web-components.esm.js"
        ></script>


brothhammer · 2025-04-07T15:33:12Z

packages/web-components/src/stories/frameworks/javascript.mdx

    rel="stylesheet"
-    href="https://unpkg.com/@astrouxds/astro-web-components/dist/astro-web-components/astro-web-components.css"
+    href="https://cdn.jsdelivr.net/npm/@astrouxds/astro-web-components/dist/astro-web-components/astro-web-components.css"
 />


brothhammer · 2025-04-07T15:33:13Z

packages/web-components/src/stories/frameworks/javascript.mdx

    type="module"
-    src="https://unpkg.com/@astrouxds/astro-web-components/dist/astro-web-components/astro-web-components.esm.js"
+    src="https://cdn.jsdelivr.net/npm/@astrouxds/astro-web-components/dist/astro-web-components/astro-web-components.esm.js"
 ></script>


Bryce Rothhammer added 4 commits April 4, 2025 14:07

update changeset config to use jsdelivr

85ade1b

remove commented out instances of unpkg

853ae97

remove more commented out instances of unpkg

4f693b4

update package.json and script tags to use jsdelivr

c7e3a7a

brothhammer commented Apr 4, 2025

View reviewed changes

packages/web-components/src/components/rux-status/test/index.html Show resolved Hide resolved

typo - remove .com

47151ca

brothhammer commented Apr 7, 2025

View reviewed changes

brothhammer marked this pull request as ready for review April 7, 2025 15:44

brothhammer requested review from FMorrison87 and kiley-mitti April 7, 2025 15:44

FMorrison87 approved these changes Apr 7, 2025

View reviewed changes

brothhammer merged commit 26e9a71 into main Apr 7, 2025
10 checks passed

brothhammer deleted the further-unpkg-for-jsdelivr branch April 7, 2025 21:37

brothhammer mentioned this pull request Apr 7, 2025

replace other unpkg with jsdelivr" #1323

Closed

7 tasks

		@@ -1,5 +1,5 @@
		{
		"$schema": "https://unpkg.com/@changesets/config@1.6.3/schema.json",

Comments

Conversation

brothhammer commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Brief Description

JIRA Link

Related Issue

General Notes

Motivation and Context

Issues and Limitations

Types of changes

Checklist

Uh oh!

changeset-bot bot commented Apr 4, 2025

⚠️ No Changeset found

Uh oh!

netlify bot commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for astro-preview ready!

Uh oh!

netlify bot commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for astro-stencil ready!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

brothhammer commented Apr 4, 2025 •

edited

Loading

netlify bot commented Apr 4, 2025 •

edited

Loading

netlify bot commented Apr 4, 2025 •

edited

Loading