remove pycache files from sdist package - #16
Merged
Conversation
when building jinxed-2.1.0 for pypi release and checking file contents,
i was surprised to see the ``__pycache__`` folder and contents, this is
from "graft tests", which includes everything, even ``.pyc`` files:
jinxed-2.1.0/tests/__pycache__/
jinxed-2.1.0/tests/__pycache__/__init__.cpython-313.pyc
jinxed-2.1.0/tests/__pycache__/__init__.cpython-314.pyc
jinxed-2.1.0/tests/__pycache__/test_terminal.cpython-313.pyc
jinxed-2.1.0/tests/__pycache__/test_terminal.cpython-314-pytest-9.0.3.pyc
jinxed-2.1.0/tests/__pycache__/test_terminal.cpython-314.pyc
jinxed-2.1.0/tests/__pycache__/test_terminfo.cpython-313.pyc
jinxed-2.1.0/tests/__pycache__/test_terminfo.cpython-314.pyc
jinxed-2.1.0/tests/__pycache__/test_tparm.cpython-313.pyc
jinxed-2.1.0/tests/__pycache__/test_tparm.cpython-314.pyc
These kinds of ``tests/__pycache__/`` and ``.pyc`` and pypy files have
been in every past jinxed sdist release except for 1.4.0 and this most
recent one, 2.1.0 where it was noticed and manually removed before
publishing.
Added global-exclude for pycache files to MANIFEST.in to prevent it.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates packaging configuration so that Python bytecode and pycache artifacts from tests are excluded from source distributions. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 57 57
Lines 710 710
Branches 31 31
=========================================
Hits 710 710 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when building jinxed-2.1.0 for pypi release and checking file contents, i was surprised to see the
__pycache__folder and contents, this is from "graft tests" in MANIFEST.in, which includeseverything:
These kinds of
tests/__pycache__/and.pycand pypy files have been in every past jinxedsdist release except for 1.4.0 and this most recent one, 2.1.0 where it was noticed and manually
removed before publishing.
Added global-exclude for pycache files to MANIFEST.in to prevent it.
Summary by Sourcery
Build: