Fix splashscreen position #728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onitor virtual desktop
Contributor
Author
|
Also sorry for the bad quality in the examples, trying two capture two displays at once is a hassle lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On multi-monitor setups, the 0.0 point of the desktop can be different from the 0.0 point of a screen, as shown here.
This quirk was causing the initial splash screen to show up on weird places if the user had multiple screens.
This PR fixes the problem by taking the current screen position into account.
Before:
https://github.com/user-attachments/assets/453e40ae-975a-418d-a44c-036243a333f7
After:
https://github.com/user-attachments/assets/e36b184d-0eef-4652-a40b-801c5097d26a
Changes were tested on Windows 11 with a dual monitor setup with 2 1920x1080 monitors, would be nice if people with different setups could test it aswell, but from what i've read in the godot docs, it should work regardless