Skip to content

Conversation

@glemsom
Copy link

@glemsom glemsom commented Aug 5, 2019

  • Use specific Ubuntu version (as per Dockerfile best practice)
  • Use version variable in Dockerfile
  • Rework required gamefiles
  • Consolidate volumes
  • Add run script to create default gamefiles

@Roemer
Copy link
Owner

Roemer commented Aug 13, 2019

Thank you for the PR. The change to one volume is breaking, so that should be noted in the readme somewhere. Also there are some non-generic strings around, especially in the run script :)
Can you update the PR, also fix the new conflicts?
Thanks

@Roemer
Copy link
Owner

Roemer commented Sep 10, 2019

Bump
Can you check my previous comment? I still would like to have that merged as I like the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants