Add m4 and a18 chipsets #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicholasR77
force-pushed
the
update-chipsets
branch
2 times, most recently
from
80bd0c6 to
0362435
Compare
NicholasR77
had a problem deploying
to
github-pages
GitHub Actions
Failure
NicholasR77
force-pushed
the
update-chipsets
branch
from
4678f69 to
26242fb
Compare
NicholasR77
force-pushed
the
update-chipsets
branch
from
54d73ad to
187daed
Compare
STachiR20
approved these changes
Jun 26, 2025
NicholasR77
commented
Jun 26, 2025
| - name: Update benchmarks | ||
| run: npm run update-benchmarks | ||
|
|
||
| - name: Validate *local* benchmark JSON shape |
There was a problem hiding this comment.
This is where we run the new test to verify that the json generated from the https://gfxbench.com/result.jsp matches the shape we expect
NicholasR77
commented
Jun 26, 2025
| const tokenizedRenderer = tokenizeForLevenshteinDistance(renderer); | ||
| // eslint-disable-next-line prefer-const | ||
| let [gpu, , , , fpsesByPixelCount] = | ||
|
|
There was a problem hiding this comment.
This is where their old code was going wrong where it was incorrectly retrieving the placement of where the fpsesByPixelCount should be - so for now to support both data shapes we just assume its the last entry in the array which seems to be accurate between how it used to look and now - if this ever changes again though our test should pick it up
Ian-Howard-R20
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.