[Hero Roller] Improves compatibility with HeroSystem6Heroic. Better Dark Mode contrast. #2004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Villain1nGlasses! Is this intentionally in draft state because you're still working on it? |
|
I was waiting until I got the go-ahead from the original author of the script. He just got back to me and it looks like he'll want to merge my changes into his working branch first before we go ahead with this update. It looks like we may close this PR, but I'm waiting for his input. |
|
Ok, looks like he's fine with me going ahead with the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1.3.0
This version improves support for HeroSystem6eHeroic, which has different attribute names than HeroSystem6e.
• Hero Roller now detects if a character is using HeroSystem6eHeroic via the sheet's attribute sheet_name. If found, Hero Roller will translate HS6e attribute names into the S6eHeroic equivalents. Otherwise, Hero Roller proceeds as per version 1.2.1.
• Hero Roller now also translates target hit location selections obtained from HS6e Heroic.
• Updated JSON with version number, sheet compatibility, and authors.
Other fixes:
• Defined font colors in chat messages to improve appearance in Dark Mode.
In the future, when the experimental attribute sheetName becomes official, Hero Roller can be updated with better support for the 5th edition sheet using the same method.