Director and Jukebox Plus Update #2090
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A script for running Theater of the Mind playstyle.
1.0.1 Added min/Max intervals, bug fixes, and simple Director integration.
1.0.1 Added min/Max intervals, bug fixes, and simple Director integration.
aikepah
reviewed
Jul 22, 2025
| const tracks = findObjs({ _type: 'jukeboxtrack' }).sort((a, b) => a.get('title').localeCompare(b.get('title'))); | ||
|
|
||
| const buildOpts = (objs, labelFn = o => o.get('name')) => | ||
| objs.map(o => `${labelFn(o)},${o.id}`).join('|'); |
There was a problem hiding this comment.
If the object's name contains a double quote, ie: Thomas "Tommy" Boy it will cause the button's href to terminate early. If we escape or replace the " with " here in buildOpts it should avoid this issue.
Suggested change
| objs.map(o => `${labelFn(o)},${o.id}`).join('|'); | |
| objs.map(o => `${labelFn(o).replace(/"/g, """)},${o.id}`).join('|'); |
There was a problem hiding this comment.
Thanks. I'll make those changes. I wasn't too concerned about breaking characters in names, because those even break vanilla macros half the time. I usually suggest to people not to include "control characters" in character and token names for that reason:
"':/(){}[], etc.
And, yeah, there was a lot of iteration on this, and it could use a cleanup sweep for abandoned code. Good catch.
Alicekb
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Director, new script to run Theater of the Mind style games
Jukebox Plus update: Added Min/Max intervals to Mix mode, bug and display fixes, and simple Director integration