refactor: simplify Diagnostic to enum, extract for_each_dep_table_mut#14
Merged
refactor: simplify Diagnostic to enum, extract for_each_dep_table_mut#14
Conversation
Replace flat Diagnostic struct (6 Option fields + CheckKind) with DiagnosticKind enum carrying variant-specific data. Add mutable variant of for_each_dep_table to eliminate duplicated iteration in fix_member_dep.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Diagnosticstruct (6 Option fields +CheckKind) withDiagnosticKindenum carrying variant-specific datafor_each_dep_table_mutto eliminate duplicated iteration infix_member_dephas_default_features_falseinto a single method chain