Skip to content

Conversation

@hannesrudolph
Copy link
Collaborator

@hannesrudolph hannesrudolph commented Nov 7, 2025

Closes: #8081

Summary

This update makes subtask hand‑offs smoother while keeping the UI exactly the same:

  • Subtasks now maintain their connection from child to parent even when VS Code has been restarted
  • Automatic parent resume: when a subtask finishes, the parent continues without a “resume task” prompt.
  • Single‑open safety: only one task is open at a time to avoid race conditions and state conflicts.

What you’ll notice

  • Fewer interruptions and faster hand‑offs between tasks.
  • No visual changes in this PR; all improvements are behavioral.

Important

This PR introduces metadata-driven subtasks with automatic parent resume and single-open safety, enhancing task management without UI changes.

  • Behavior:
    • Adds metadata-driven subtasks with automatic parent resume and single-open safety.
    • Introduces new events: TaskDelegated, TaskDelegationCompleted, and TaskDelegationResumed in ExtensionChannel.ts and ClineProvider.ts.
    • Ensures only one task is open at a time to avoid race conditions.
  • Task Lifecycle:
    • Updates Task.ts to handle delegation events and resume parent tasks automatically.
    • Removes legacy subtask handling methods like completeSubtask().
  • Testing:
    • Adds tests for delegation events in ExtensionChannel.test.ts and ClineProvider.spec.ts.
    • Introduces new test files for delegation scenarios, such as delegation-events.spec.ts and nested-delegation-resume.spec.ts.
  • Localization:
    • Updates localization files to include new task delegation strings in multiple languages.

This description was created by Ellipsis for 4cad931. You can customize this summary. It will automatically update as commits are pushed.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 7, 2025
@hannesrudolph hannesrudolph moved this from Triage to PR [Draft / In Progress] in Roo Code Roadmap Nov 7, 2025
@hannesrudolph hannesrudolph added PR - Draft / In Progress and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Nov 7, 2025
@hannesrudolph hannesrudolph force-pushed the feat/metadata-delegation-subtasks-qa branch 4 times, most recently from d734788 to 05e6a98 Compare November 13, 2025 00:13
@hannesrudolph hannesrudolph marked this pull request as ready for review November 13, 2025 00:14
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. documentation Improvements or additions to documentation Enhancement New feature or request labels Nov 13, 2025
@roomote
Copy link
Contributor

roomote bot commented Nov 13, 2025

Oroocle Clock   Follow along on Roo Cloud

Re-review at 4cad931b4f273e5a7d75eb9ee604c99814c69dfd: focusing on metadata-driven subtasks, automatic parent resumption, and single-open safety behavior introduced since the last review.

  • SkipPrevResponse flag is correctly wired for delegation resume and behaves as intended
  • Checkpoint delegation abort noise prevention tests remain in place and cover the critical scenarios
  • Partial completion telemetry handler still emits TaskCompleted on partial chunks, which can cause premature or duplicate completion signaling
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph changed the title Metadata-driven subtasks: delegation flow, auto-resume, nested returns, UI badges, tests, docs Metadata‑driven subtasks (no UI changes): automatic parent resume and single‑open safety Nov 13, 2025
Copy link
Contributor

@roomote roomote bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping the entire test suite defeats the purpose of having tests for critical abort noise prevention logic. If these tests are no longer relevant due to the refactor, they should be updated to reflect the new implementation rather than disabled. This leaves the checkpoint abort handling untested and could allow regressions in error handling during task disposal.

Fix it with Roo Code or mention @roomote and request a fix.

@hannesrudolph hannesrudolph force-pushed the feat/metadata-delegation-subtasks-qa branch from 1977ea5 to b47a930 Compare November 13, 2025 00:57
@hannesrudolph hannesrudolph merged commit 9b5f639 into main Nov 28, 2025
10 checks passed
@hannesrudolph hannesrudolph deleted the feat/metadata-delegation-subtasks-qa branch November 28, 2025 04:18
@github-project-automation github-project-automation bot moved this from PR [Needs Prelim Review] to Done in Roo Code Roadmap Nov 28, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation Enhancement New feature or request lgtm This PR has been approved by a maintainer PR - Needs Preliminary Review size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG] Subtask completes but doesn’t return to parent after interruptions

4 participants