Skip to content

Conversation

@roomote
Copy link
Contributor

@roomote roomote bot commented Nov 8, 2025

Summary

This PR attempts to address Issue #9135 by fixing the misleading shell integration warning message.

Problem

Users were receiving a warning about VSCode terminal shell integration that referenced a non-existent setting:

  • The warning said to "disable shell integration in the Terminal section"
  • But there was no such setting to disable shell integration
  • The actual setting is "Use Inline Terminal" which, when enabled, bypasses shell integration

Solution

Updated the warning message in the English localization file to correctly guide users to:

  • Enable the "Use Inline Terminal" option (which effectively suppresses the warning by using inline terminal instead of VSCode terminal with shell integration)
  • This makes the warning message match the actual available setting

Changes

  • Updated to reference "Use Inline Terminal" instead of the non-existent "disable shell integration" option

Testing

  • Linting and type checking passed successfully
  • The change is a simple text update that doesn't affect functionality

Note to maintainers

This is my attempt at addressing the issue. If you need the change applied to other language files as well, I'm happy to update those too. Feedback and guidance are welcome!

Fixes #9135


Important

Updates shell integration warning in chat.json to reference "Use Inline Terminal" setting, addressing Issue #9135.

  • Behavior:
    • Updates shell integration warning message in chat.json to reference "Use Inline Terminal" instead of non-existent "disable shell integration" option.
    • Affects the warning message shown when commands are executed without VSCode terminal shell integration.
  • Testing:
    • Linting and type checking passed.
    • Change is a text update, no functional impact.
  • Misc:

This description was created by Ellipsis for 2d2531c. You can customize this summary. It will automatically update as commits are pushed.

…e Terminal' setting

- Fixed misleading warning message that referenced non-existent 'Disable shell integration' option
- Updated to correctly guide users to the 'Use Inline Terminal' setting in Terminal section
- This resolves the confusion reported in issue #9135

Fixes #9135
@roomote roomote bot requested review from cte, jr and mrubens as code owners November 8, 2025 18:42
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. documentation Improvements or additions to documentation labels Nov 8, 2025
@roomote
Copy link
Contributor Author

roomote bot commented Nov 8, 2025

Rooviewer Clock   See task on Roo Cloud

Review complete. This PR correctly addresses Issue #9135 by updating the shell integration warning message to reference the actual "Use Inline Terminal" setting instead of the non-existent "disable shell integration" option. No issues found.

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

[BUG] Constant warnings about no VSCode terminal shell integration, yet shell works

3 participants