Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Nov 25, 2025

Important

Add support for images_api method in image generation, including new model and tests.

  • Behavior:
    • Adds support for images_api method in RooHandler and OpenRouterHandler for image generation.
    • Updates GenerateImageTool to select API method based on model info.
    • Adds new model bfl/flux-2-pro using images_api.
  • Functions:
    • Adds generateImageWithImagesApi() in image-generation.ts for handling images_api requests.
    • Updates generateImageWithProvider() to handle both API methods.
  • Tests:
    • Adds tests for generateImageWithImagesApi() in image-generation.spec.ts.
    • Updates tests for generateImageWithProvider() to ensure compatibility with both API methods.

This description was created by Ellipsis for 73ced2d. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners November 25, 2025 18:22
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. Enhancement New feature or request labels Nov 25, 2025
@roomote
Copy link
Contributor

roomote bot commented Nov 25, 2025

Rooviewer Clock   See task on Roo Cloud

All previously flagged issues have been resolved. The PR is ready for approval.

  • Test expects /images/edits endpoint but implementation uses /images/generations (test file lines 204-230)
  • Missing URL response handling - only checks b64_json but API can return url field (image-generation.ts line 271)
Previous reviews

Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Nov 25, 2025
@mrubens mrubens merged commit e4847ed into main Nov 25, 2025
10 checks passed
@mrubens mrubens deleted the roo_image_api branch November 25, 2025 19:18
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Nov 25, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants