Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration/validate subshell commands #1001

Open
wants to merge 7 commits into
base: validate_subshell_commands
Choose a base branch
from

Conversation

tapvt
Copy link

@tapvt tapvt commented Feb 14, 2025

Description

Pretty much just clean-up to resolve merge conflicts against main in validate_subshell_commands pull request.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

Related Issues

Reviewers


Important

Refactor ChatView.tsx for improved command validation and auto-approval, update ESLint configuration, and enhance tests for new logic.

  • Behavior:
    • Refactor ChatView.tsx to improve command validation and auto-approval logic.
    • Add isAllowedCommand and isAutoApproved functions to handle command validation and auto-approval.
    • Update useEffect hooks to manage message handling and UI updates.
  • Configuration:
    • Add .eslintrc.json for ESLint configuration in webview-ui.
    • Update @testing-library/react dependency in package.json to ^14.2.1.
  • Tests:
    • Update HistoryView.test.tsx and SettingsView.test.tsx to handle new command validation logic.
    • Add suppression for act() warnings in HistoryView.test.tsx.

This description was created by Ellipsis for 8ba9eec. It will automatically update as commits are pushed.

Copy link

changeset-bot bot commented Feb 14, 2025

⚠️ No Changeset found

Latest commit: 61bfb60

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mrubens
Copy link
Collaborator

mrubens commented Feb 16, 2025

Can you remind me which the original PR is here and what changes it makes? I’m on my phone so hard for me to dig in, but I thought we already did validate subshell commands. Thanks!

@mosleyit
Copy link

@mrubens #232

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants