-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement/task delete confirmation 854 #1100
base: main
Are you sure you want to change the base?
Improvement/task delete confirmation 854 #1100
Conversation
…ation through a modal dialog. This improves the user experience by adding a safety check before performing irreversible actions.
|
Can you switch to a Radix UI Dialog Modal instead of the VScode native modal? |
…g component for task deletion confirmation. The change provides a more consistent user experience by using the same design system as the rest of the application. Changes: Add new DeleteTaskDialog component using Radix UIs AlertDialog Update HistoryView to manage dialog state and task deletion flow Remove VSCode native dialog from ClineProvider.ts
Per @hannesrudolph request this has been moved to us Radix UI Alert Dialog to fit the project structure better |
Can you update the pic in the PR? |
@hannesrudolph that is complete. Sorry for the oversite. |
Beautiful @mrubens take a look when you get a chance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Looks like a test failure though |
Test needs to handle the delete confirmation. Will update |
Description
Type of change
How Has This Been Tested?
Manual testing no failing unit tests
Checklist:
Additional context
--edit to show corrected image
Related Issues
Fixes #854
Reviewers
Important
Adds a confirmation dialog in
deleteTaskWithId()
inClineProvider.ts
to confirm task deletion.deleteTaskWithId()
inClineProvider.ts
to confirm task deletion.This description was created by
for 2fd3431. It will automatically update as commits are pushed.